build: support Python 3.13 conversion dependencies#417
Open
darsh7807 wants to merge 1 commit intomicrosoft:mainfrom
Open
build: support Python 3.13 conversion dependencies#417darsh7807 wants to merge 1 commit intomicrosoft:mainfrom
darsh7807 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix installation on Python 3.13 for the conversion dependency set used by BitNet's top-level
requirements.txt.Root cause
BitNet's top-level requirements included vendored
llama.cpprequirement files that pintorch~=2.2.1. That torch line does not providecp313wheels, souv pip install -r requirements.txtfails on Python 3.13 with an unsatisfiable dependency resolution error.Changes
llama.cppfiles directlytorch~=2.2.1for Python<3.13torch>=2.5.0,<3.0.0for Python>=3.13Why this approach
The torch incompatibility exists in vendored submodule requirement files, but BitNet consumes those files through its own top-level
requirements.txt. Using BitNet-local wrappers fixes installation behavior without modifying the submodule directly.Verification
Before
On clean
main:Result:
torch~=2.2.1has no matchingcp313wheelsAfter
On this branch:
Result:
torch==2.10.0Regression check:
Result:
torch==2.2.2Closes #413