Remove installPython from checks which should no longer need it#3549
Merged
Remove installPython from checks which should no longer need it#3549
installPython from checks which should no longer need it#3549Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes explicit Python installation from PR-check templates where it’s no longer needed, reducing workflow setup while keeping the remaining Python pinning in the one check that still exercises older CodeQL CLI versions.
Changes:
- Dropped
installPython: truefrom severalpr-checks/checks/*.ymlspecs. - Regenerated the corresponding
.__*.ymlworkflows to remove thesetup-pythonstep,python-versioninputs, and Python from the concurrency group key.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pr-checks/checks/with-checkout-path.yml | Removes installPython from the check spec. |
| pr-checks/checks/upload-sarif.yml | Removes installPython from the check spec. |
| pr-checks/checks/upload-ref-sha-input.yml | Removes installPython from the check spec. |
| pr-checks/checks/unset-environment.yml | Removes installPython from the check spec. |
| pr-checks/checks/remote-config.yml | Removes installPython from the check spec. |
| pr-checks/checks/packaging-codescanning-config-inputs-js.yml | Removes installPython from the check spec. |
| pr-checks/checks/local-bundle.yml | Removes installPython from the check spec. |
| pr-checks/checks/analyze-ref-input.yml | Removes installPython from the check spec. |
| .github/workflows/__with-checkout-path.yml | Regenerated workflow output reflecting removal of Python install/input. |
| .github/workflows/__upload-sarif.yml | Regenerated workflow output reflecting removal of Python install/input. |
| .github/workflows/__upload-ref-sha-input.yml | Regenerated workflow output reflecting removal of Python install/input. |
| .github/workflows/__unset-environment.yml | Regenerated workflow output reflecting removal of Python install/input. |
| .github/workflows/__remote-config.yml | Regenerated workflow output reflecting removal of Python install/input. |
| .github/workflows/__packaging-codescanning-config-inputs-js.yml | Regenerated workflow output reflecting removal of Python install/input. |
| .github/workflows/__local-bundle.yml | Regenerated workflow output reflecting removal of Python install/input. |
| .github/workflows/__analyze-ref-input.yml | Regenerated workflow output reflecting removal of Python install/input. |
henrymercer
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We added explicit
setup-pythonsteps to PR checks a while back because the default CodeQL CLI version at the time had a bug when used with the (then new) default Python version on Actions runners.The default CodeQL CLI version should not contain the fix, so this is no longer necessary for any PR check other than
multi-language-autodetect.ymlwhich uses thedefaultTestVersionsand so includes some older CLI versions which predate the fix.I think that the last CLI version without a fix would have been https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.23.3, so we could also (separately) look at making the remaining
setup-pythonstep conditional for versions below that, rather than!nightly-latest.Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Environments:
How did/will you validate this change?
pr-checks).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist