Skip to content

Remove installPython from checks which should no longer need it#3549

Merged
mbg merged 1 commit intomainfrom
mbg/pr-checks/remove-python-setup
Mar 9, 2026
Merged

Remove installPython from checks which should no longer need it#3549
mbg merged 1 commit intomainfrom
mbg/pr-checks/remove-python-setup

Conversation

@mbg
Copy link
Member

@mbg mbg commented Mar 5, 2026

We added explicit setup-python steps to PR checks a while back because the default CodeQL CLI version at the time had a bug when used with the (then new) default Python version on Actions runners.

The default CodeQL CLI version should not contain the fix, so this is no longer necessary for any PR check other than multi-language-autodetect.yml which uses the defaultTestVersions and so includes some older CLI versions which predate the fix.

I think that the last CLI version without a fix would have been https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.23.3, so we could also (separately) look at making the remaining setup-python step conditional for versions below that, rather than !nightly-latest.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Environments:

  • Testing/None - This change does not impact any CodeQL workflows in production.

How did/will you validate this change?

  • End-to-end tests - I am depending on PR checks (i.e. tests in pr-checks).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Development/testing only - This change cannot cause any failures in production.

How will you know if something goes wrong after this change is released?

  • Other - Please provide details.

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

@mbg mbg self-assigned this Mar 5, 2026
@github-actions github-actions bot added the size/XS Should be very easy to review label Mar 5, 2026
@mbg mbg marked this pull request as ready for review March 9, 2026 13:55
@mbg mbg requested a review from a team as a code owner March 9, 2026 13:55
Copilot AI review requested due to automatic review settings March 9, 2026 13:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes explicit Python installation from PR-check templates where it’s no longer needed, reducing workflow setup while keeping the remaining Python pinning in the one check that still exercises older CodeQL CLI versions.

Changes:

  • Dropped installPython: true from several pr-checks/checks/*.yml specs.
  • Regenerated the corresponding .__*.yml workflows to remove the setup-python step, python-version inputs, and Python from the concurrency group key.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pr-checks/checks/with-checkout-path.yml Removes installPython from the check spec.
pr-checks/checks/upload-sarif.yml Removes installPython from the check spec.
pr-checks/checks/upload-ref-sha-input.yml Removes installPython from the check spec.
pr-checks/checks/unset-environment.yml Removes installPython from the check spec.
pr-checks/checks/remote-config.yml Removes installPython from the check spec.
pr-checks/checks/packaging-codescanning-config-inputs-js.yml Removes installPython from the check spec.
pr-checks/checks/local-bundle.yml Removes installPython from the check spec.
pr-checks/checks/analyze-ref-input.yml Removes installPython from the check spec.
.github/workflows/__with-checkout-path.yml Regenerated workflow output reflecting removal of Python install/input.
.github/workflows/__upload-sarif.yml Regenerated workflow output reflecting removal of Python install/input.
.github/workflows/__upload-ref-sha-input.yml Regenerated workflow output reflecting removal of Python install/input.
.github/workflows/__unset-environment.yml Regenerated workflow output reflecting removal of Python install/input.
.github/workflows/__remote-config.yml Regenerated workflow output reflecting removal of Python install/input.
.github/workflows/__packaging-codescanning-config-inputs-js.yml Regenerated workflow output reflecting removal of Python install/input.
.github/workflows/__local-bundle.yml Regenerated workflow output reflecting removal of Python install/input.
.github/workflows/__analyze-ref-input.yml Regenerated workflow output reflecting removal of Python install/input.

@mbg mbg added this pull request to the merge queue Mar 9, 2026
Merged via the queue into main with commit f054eea Mar 9, 2026
482 of 483 checks passed
@mbg mbg deleted the mbg/pr-checks/remove-python-setup branch March 9, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Should be very easy to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants